Game factoring and heroes

[Turock]

Doesn't seem like the game factoring is working properly with reguards to getting a hero. After 1000 turns and game factoring set at 1/1000:

Currently, getting a hero requires:
1,016,500 Infantry
508,250 Phalanx
169,417 Trebuchets
2,059 Frigates
162,640 Mages
12,000 acres
80 health
395 turns


There's no way that is right

[Devari]

I am guessing that hero.html (or whatever the template is) is not getting gamefactor applied to the values on it. As far as I know all you would need to do is to change {$food} to {$food|gamefactor} and so on, although I may be forgetting one step along the road...

[Devari]

And, of course, the reason for that bug is because nobody thought to check it; after all, we haven't used heroes since factoring was implement!

As an interesting point, however, I do believe you should actually be able to get a hero; as far as I know, 1000 Spearmen is still stored in the database as 1000000 Spearmen. Might be wrong, though.

[Turock]

Yea you are right in all cases. Its just displaying incorectly, but should still work.

Heres the changes I made.

Line 83 in hero.html:

code: Select all

<li><span class="{if $tr[i].ok == 1}cgood{else}cwarn{/if}"><b>{$tr[i].reqd}</b> {$tr[i].name}</span></li>

Should be:

code: Select all

<li><span class="{if $tr[i].ok == 1}cgood{else}cwarn{/if}"><b>{$tr[i].reqd|gamefactor}</b> {$tr[i].name}</span></li>

-- Edit:
There are a few more changes than what I initially thought
There needs to be a few more arrays created in order to display the required land, health and turns properly because you don't want those to be factored.