BUG: Images in Clan Crier

As bugs and suggestions are fixed/implemented/rejected, they will be moved in here.
Post Reply
User avatar
Urran Voh
I have a BS degree!
Posts: 2080
Joined: Sun Apr 25, 2004 8:58 pm
Location: Olive Branch, Mississippi
Contact:

Post by Urran Voh »

Can we not put images in the clan crier?

I get
Warning: Division by zero in /home/staron/public_html/faf/SampleParser.php on line 199
Kills from all Promi games: 55

Emperor and winner of BFR during the 11th Age

Image

Image

Image

Image
sh0e
Forum Maniac
Posts: 290
Joined: Mon Apr 19, 2004 6:13 pm

Post by sh0e »

the width seems to somehow be 0 for your image
link to image please?

EDIT:
nvm.. it is reading the jpg dimensions as 0x0
i fixed the if statement on dev line 189 to detect props as faulty if either dimension is 0
http://dev.staronesw.com/?source&script=SampleParser&lines=1

NOTE:
i have been extremely lazy about backporting/merging fixes to non dev
i hate the feeling of grunt work it shows
User avatar
Urran Voh
I have a BS degree!
Posts: 2080
Joined: Sun Apr 25, 2004 8:58 pm
Location: Olive Branch, Mississippi
Contact:

Post by Urran Voh »

I keep forgetting to specify what server...'Tis BFR.

Image is
Kills from all Promi games: 55

Emperor and winner of BFR during the 11th Age

Image

Image

Image

Image
User avatar
The Beatles
Fear me for I am root
Posts: 6285
Joined: Tue May 24, 2005 8:12 pm

Post by The Beatles »

As long as it works on dev.staronesw.com (please try it), there is absolutely no priority in fixing them on regular servers.
:wq
sh0e
Forum Maniac
Posts: 290
Joined: Mon Apr 19, 2004 6:13 pm

Post by sh0e »

just thought i should mention:
getimagesize() from the image library is far more compatible than get_imgsize()(lib/imagesize.php)
but i assume that you are using lib/imagesize.php in case the image lib module isnt compiled in

EDIT: additional fix to allow using getimagesize() or lib/imagesize.php depending on whether getimagesize() exists
User avatar
The Beatles
Fear me for I am root
Posts: 6285
Joined: Tue May 24, 2005 8:12 pm

Post by The Beatles »

No, actually, that wasn't my code you see. (See Credits.) Thanks! ;)
:wq
Post Reply
  • Members connected in real time

    🔒 Close the panel of connected members