CANTVERIFY: Market Sell News Bug

[The Beatles]

1 days, 13.6 hours ago You sold 2,839 Mice on the market for $729,704,842.
The cash is available in the Bank.

That's $257,028 per mouse.

[Veranor]

• Did he actually sell that many mice? - (IE: He actually sold more like 2,839,xxx mice)</li>
• Did he actually get that much money? (Did he end up getting that much in his bank or was that simply what was reported in the news?)</li>
• Had this news been condensed?</li>

Maybe related: seems like addNews's autocondenser ("old" vs "new" query based on num rows) might act unexpectedly at times. It loads the last query executed and then sees if it matches, if no it considers the query new. This seems odd, because a pattern like:

• Player A (#2) buys 500,000 mice</li>
• Player B (#3) attacks Player C (#4)</li>
• Player A (#2) buys 200,000 mice</li>

should condense player A's news since they're the same thing and B and C have no actual bearing on Player A's actions. However, this will not condense based on the current setup. Shouldn't the query for the recent news be a little more specific than just the most recent query in the past X minutes? Consider:
Current:

code: Select all

$last_q = mysql_query("SELECT * FROM $newsdb WHERE time>$limit ORDER BY id DESC LIMIT 0,1;");

....

if( $code == $old[code] && $id1 == $old[id1] && $clan1 == $old[clan1] &&
            $id2 == $old[id2] && $clan2 == $old[clan2] && $id3 == $old[id3] &&
            $clan3 == $old[clan3] && $shielded == $old[shielded]) {

Proposed

code: Select all

SELECT * FROM $newsdb WHERE time>$limit AND code=$code AND $id1=$id1 AND $clan1=$clan1 $id2=$id2 AND ... so on and so forth

What happens if two troop strings of 5||| and ||6| are combined? Does it output 5||6| or might some entry be destroyed? Perhaps he sold two different types of troops in two transactions that were condensed but one type's entry got destroyed?

[Nuclear Raunch]

That was my empire and I could not check much since I was killed. Do not know about the cash part, I do know that was all the mice I had on the market. I did have other types of troops on the market though.

I'm, sorry man, I normally try to get as much information as possible when reporting a bug but in this case I was very limited as to what I could check out.

[The Beatles]

Vera -- those two actions should not actually be condensed, because consider things like war. Suppose A attacks B 5 times, C attacks B once, and A attacks B 5 more times. I don't think that we should condense A's attacks in such a case.

As to your second question -- I believe it is handled correctly, but I can't of course guarantee it 100%.

[Devari]

Can anyone please verify this bug?

[Devari]

Still need a verify, or at least a lead to go on.

[Ruddertail]

I haven't noticed anything of the like recently, but I don't sell much on the market. Most of my stuff is so high priced, only sombody who'd already bought out the bazzar and still needed more troops would consider it. A few rounds back, somebody (I think it was Nohc or Scar) was running a market selling strat. They might have noticed something.

[Devari]

Well, I'm closing it for now. Maybe if something comes up later, I'll reopen. If there is a bug, Vera's post could rather help diagnose it.

[The Beatles]

I moved it back to Active Bugs just in case. I was cleaning out the old Archived topics you see.

[Devari]

Anyone want to take a crack at resolving this one, or should we finally put it to rest?

[Gen. Volkov]

I think it was prolly related to my bug discovery, you know, where I got ricidumoney from ships?

[The Beatles]

This was much earlier.

[Devari]

Pre-scaling, yes. Although I can see why Volkov might think that.

[Gen. Volkov]

Oh, ok, I see. NVM then.

[Freenhult]

Anyone want to take a crack at resolving this one, or should we finally put it to rest?

Me and Noch will try and test it out. This should work for the clan market I hope.